Skip to content

🐛 Bug: Put back thought-to-be-unnecessary .all-contributorsrc properties #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
JoshuaKGoldberg opened this issue Apr 11, 2025 · 1 comment · Fixed by #2204
Closed
3 tasks done
Assignees
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Apr 11, 2025

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

The all-contributors bot is stuck on an old version of the all-contributors CLI, and that CLI is also known to add some redundant properties to the file: e.g. all-contributors/cli#369. All redundant properties should be kept in the file so that the bot doesn't add extra noise in PRs.

Actual

Back in #1783 -> #1784 I'd removed unnecessary default values from .all-contributorsrc. Silly me.

Additional Info

https://github.com/JoshuaKGoldberg/should-semantic-release/pull/571/files is an example of the bot adding them back.

🎁

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :( labels Apr 11, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 11, 2025
Copy link

🎉 This is included in version v2.40.5 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant