Skip to content

🚀 Feature: Hydration script should call the same GitHub APIs as the setup script #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
JoshuaKGoldberg opened this issue May 20, 2023 · 1 comment
Closed
3 tasks done
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented May 20, 2023

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

This repo has two scripts that can run to set up a repository:

Right now, the setup script calls to GitHub APIs to set up repository labels and assorted other GitHub repository settings. But the hydration script doesn't do that...

...yet! Let's have the hydration script call to those same APIs.

Additional Info

I think we should find a way to share code between the two scripts. It'd be annoying to have the code exist in two locations. Perhaps moving the setup script to inside src/? Note that the setup script should be written in .js files so that folks don't have to run pnpm build before running it. We'd want to enable checkJs in tsconfig.json, I think. #468

We'll also want at least one --skip-* flag the same way that the setup script does. I'd want to be able to run this thing without modifying the main/upstream repository!

@JoshuaKGoldberg
Copy link
Owner Author

Ah, this was resolved by #489.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

1 participant