Skip to content

feat: add hydration script for existing repos #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 19, 2023
Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented May 16, 2023

PR Checklist

Overview

Adds the script as a bin command you can run with npx template-typescript-node-package. Which bumps up a few dependencies from devDependency to dependency.

This has the nice side effect of standardizing formatting for an assortment of files. Hence the large Files changed count outside of the new src/hydrate/ directory.

Things I've intentionally not done here, so they can be filed as followup issues:

  • Filling in unit test coverage
  • Running all-contributors-for-repository to fill in the .all-contributorsrc
  • Removing existing image badges from the README.md
  • Removing existing CODE_OF_CONDUCT.md
  • Use the GitHub API to set up labels and other repo settings
  • Run pnpm run lint --fix
  • CLI flag for hydration to just refresh files locally
  • Getting hydration to the point where it doesn't make changes in this repo (is that possible?)
  • A copy&pastable script to run in a repo to update it to the latest tooling (migrations?!)

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #441 (5e752fc) into main (3ee08b7) will decrease coverage by 26.23%.
The diff coverage is 72.64%.

❗ Current head 5e752fc differs from pull request most recent head c5d24da. Consider uploading reports for the commit c5d24da to get more accurate results

@@             Coverage Diff              @@
##              main     #441       +/-   ##
============================================
- Coverage   100.00%   73.77%   -26.23%     
============================================
  Files            1       23       +22     
  Lines            5      122      +117     
  Branches         3       42       +39     
============================================
+ Hits             5       90       +85     
- Misses           0       10       +10     
- Partials         0       22       +22     
Impacted Files Coverage Δ
src/hydrate/index.ts 0.00% <0.00%> (ø)
src/hydrate/readFileSafe.ts 0.00% <0.00%> (ø)
src/hydrate/creation/rootFiles.ts 33.33% <33.33%> (ø)
src/hydrate/hydrate.ts 50.00% <50.00%> (ø)
src/hydrate/readFundingIfExists.ts 66.66% <66.66%> (ø)
src/hydrate/writeReadme.ts 66.66% <66.66%> (ø)
src/hydrate/writing.ts 89.47% <89.47%> (ø)
src/hydrate/clearUnnecessaryFiles.ts 100.00% <100.00%> (ø)
src/hydrate/creation/dotGitHub/actions.ts 100.00% <100.00%> (ø)
...c/hydrate/creation/dotGitHub/createWorkflowFile.ts 100.00% <100.00%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This is included in version v1.28.1 🎉

The release is available on:

Cheers! 📦🚀

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This is included in version v1.28.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Add a script that can apply this repo's tooling to an existing repo
1 participant