Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Allow hydration/migration to run on an empty directory #669

Closed
3 tasks done
JoshuaKGoldberg opened this issue Aug 21, 2023 · 1 comment · Fixed by #673
Closed
3 tasks done

🚀 Feature: Allow hydration/migration to run on an empty directory #669

JoshuaKGoldberg opened this issue Aug 21, 2023 · 1 comment · Fixed by #673
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

"Migration" (before #668, "hydration") right now requires a directory to at least have a package.json and be a Git repo (i.e. initialized with git init or git clone). But it wouldn't be much work to be able to run on an empty directory. That'll make testing the hydration/migration script out easier.

Additional Info

Splitting out of the changes from #668.
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Aug 21, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 21, 2023
This was referenced Aug 21, 2023
Closed
Closed
Merged
JoshuaKGoldberg added a commit that referenced this issue Aug 21, 2023
@JoshuaKGoldberg
feat: allowed hydration directory to be empty (#673)
597e6da 
## PR Checklist

- [x] Addresses an existing open issue: fixes #669
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Changes split out of #668:

* If `git status` fails, runs `git init` to make the directory a repo
* Allows `package.json` to be empty, defaulting its contents to `{}`
@github-actions
Copy link

🎉 This is included in version v1.28.56 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 22, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allowed hydration directory to be empty JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg