Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add verbose logging #708

Closed
3 tasks done
JoshuaKGoldberg opened this issue Aug 25, 2023 · 1 comment · Fixed by #710
Closed
3 tasks done

🚀 Feature: Add verbose logging #708

JoshuaKGoldberg opened this issue Aug 25, 2023 · 1 comment · Fixed by #710
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Ready to Rename

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Aug 25, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Now that I simplified the CLI output (#681, #695), running npx template-typescript-node-package sometimes appears to be "stuck" on Migrating repository structure... or other long commands. It'd be nice to have a way to ask for more logging.

https://npmjs.com/package/debug is a popular way to do this. We use it in typescript-eslint. I'll use it here. I don't like how this would necessitate redoing a bunch of the CLI outputs. I'll trim this task down a bit to just add more logs when a --verbose flag is passed.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Aug 25, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Ready to Launch milestone Aug 25, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 25, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🚀 Feature: Add verbose logging with the debug package 🚀 Feature: Add verbose logging Aug 26, 2023
This was referenced Aug 26, 2023
Merged
Open
JoshuaKGoldberg added a commit that referenced this issue Aug 26, 2023
@JoshuaKGoldberg
feat: added sub-spinner labels for some spinner task groups (#710)
dc634e6 
## PR Checklist

- [x] Addresses an existing open issue: fixes #708
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

For some longer-running spinners that had multiple sub-tasks, adds a new
`withSpinners` function that takes in an array of labeled tasks. The CLI
output for that one shows the list of completed tasks & running task
under the parent group, then clears that list once it's done.


https://github.com/JoshuaKGoldberg/template-typescript-node-package/assets/3335181/4c26d831-5d3a-438b-96ce-7afaeba3bd0b
@github-actions
Copy link

🎉 This is included in version v1.29.8 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Ready to Rename
Development

Successfully merging a pull request may close this issue.

feat: added sub-spinner labels for some spinner task groups JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg