Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Replace format:write with format --write #762

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 2, 2023 · 1 comment · Fixed by #901
Closed
3 tasks done

🚀 Feature: Replace format:write with format --write #762

JoshuaKGoldberg opened this issue Sep 2, 2023 · 1 comment · Fixed by #901
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Sep 2, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, this repo references two ways of applying formatting to files:

  • pnpm format --write: using the format script defined in the package.json, with a --write flag
  • pnpm format:write: using the format:write script defined in the package.json, which runs `pnpm format --write

There's no need to have both. Other auto-fixable CLI scripts such as lint don't have a dedicated :write. Let's remove format:write and replace it with format --write.

Additional Info

You'll want to find-and-replace in all files to catch all references to format:write.
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Sep 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 2, 2023
@DanexQ DanexQ mentioned this issue Sep 7, 2023
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 29, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Sep 29, 2023
@JoshuaKGoldberg
feat: switch format:write to format --write (#901)
4486186 
## PR Checklist

- [x] Addresses an existing open issue: fixes #762
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Does the swap, both in code and docs.
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Post-Rename Migration
1 participant
@JoshuaKGoldberg