Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Run pnpm dedupe at the end of finalizeDependencies #770

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 3, 2023 · 1 comment · Fixed by #902
Closed
3 tasks done

🚀 Feature: Run pnpm dedupe at the end of finalizeDependencies #770

JoshuaKGoldberg opened this issue Sep 3, 2023 · 1 comment · Fixed by #902
Assignees
@JoshuaKGoldberg
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

finalizeDependencies is the function that sets up the package's dependencies:

create-typescript-app/src/steps/finalizeDependencies.ts

Line 6 in 5127bcb

export async function finalizeDependencies(options: Options) {

But it's possible for older repos to have duplicate values in their pnpm-lock.yaml (i.e. violating pnpm dedupe --check). So let's run pnpm dedupe at the end of `finalizeDependencies.

await $`pnpm dedupe`;

Additional Info

https://pnpm.io/cli/dedupe describes what pnpm dedupe does.
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Sep 3, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 3, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 29, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Sep 29, 2023
@JoshuaKGoldberg
feat: run npm dedupe at end of finalizeDependencies (#902)
8f7692a 
## PR Checklist

- [x] Addresses an existing open issue: fixes #770
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds with `execaCommand` since it's already being used.
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Post-Rename Migration
Development

Successfully merging a pull request may close this issue.

feat: run npm dedupe at end of finalizeDependencies JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg