Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Branch protection settings still refer to lint_package, not lint_package_json #778

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 4, 2023 · 1 comment · Fixed by #779
Closed
3 tasks done

🐛 Bug: Branch protection settings still refer to lint_package, not lint_package_json #778

JoshuaKGoldberg opened this issue Sep 4, 2023 · 1 comment · Fixed by #779
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Back in #695, I'd renamed lint:package to lint:package-json to make the naming more distinct from lint:packages.

Actual

But I never updated the lint_package name in a few places. For consistency, let's switch it to lint_package_json.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Sep 4, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 4, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 4, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 4, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Sep 4, 2023
@JoshuaKGoldberg
fix: update branch protection settings for lint_package-json (#779)
70d6937 
## PR Checklist

- [x] Addresses an existing open issue: fixes #778
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Mostly a find-and-replace.
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🎉 This is included in version v1.29.32 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Post-Rename Migration
Development

Successfully merging a pull request may close this issue.

fix: update branch protection settings for lint_package-json JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg