Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Enable noEmit: true in tsconfig.json #800

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 5, 2023 · 1 comment · Fixed by #888
Closed
3 tasks done

🛠 Tooling: Enable noEmit: true in tsconfig.json #800

JoshuaKGoldberg opened this issue Sep 5, 2023 · 1 comment · Fixed by #888
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this!
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

This repository used to use tsc (the TypeScript CLI) to emit .js files. As of #640 it now uses tsup. So pnpm run tsc is just a type checking task.

But, tsconfig.json doesn't have "noEmit": true enabled (https://aka.ms/tsconfig#noEmit). So running pnpm run tsc still outputs .js files. That's not what we want!

Let's add "noEmit": true to the tsconfig.json file.

Additional Info

The template data for tsconfig.json files will also need to be updated:

create-typescript-app/src/steps/writing/creation/rootFiles.ts

Line 152 in f4f0233

"tsconfig.json": await formatJson({

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Sep 5, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 5, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 25, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Sep 25, 2023
@JoshuaKGoldberg
feat: enable noEmit in tsconfig.json (#888)
617dcc4 
## PR Checklist

- [x] Addresses an existing open issue: fixes #800
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Updates the repo's `tsconfig.json` file and backing template.
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
Post-Rename Migration
Development

Successfully merging a pull request may close this issue.

feat: enable noEmit in tsconfig.json JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg