🐛 Bug: Releases can become broken after two quick pushes to main #862
Labels
status: accepting prs
Please, send a pull request to resolve this!
type: bug
Something isn't working :(
Milestone
Bug Report Checklist
main
branch of the repository.Expected
Back in #556 I'd requested changing the release workflow to
cancel-in-progress: true
. The idea was that if they were running in series, later workflows wouldn't have up-to-date commits frommain
. I'd thought this would fix the checked-in version to always be in sync with what was published to npm.The general flow is meant to be:
Actual
Unfortunately, there's still a race condition. Take the following order:
Note that Commit A's Git commit was never pushed to GitHub.
Additional Info
Example CI failure: https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/6262715180/job/17005549976
Looks like https://github.com/orgs/community/discussions/12835 discusses proposals for a built-in way to avoid this classification of issue.
The text was updated successfully, but these errors were encountered: