Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add an explicit opt-in --offline mode #878

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 22, 2023 · 1 comment · Fixed by #879
Closed
3 tasks done

🚀 Feature: Add an explicit opt-in --offline mode #878

JoshuaKGoldberg opened this issue Sep 22, 2023 · 1 comment · Fixed by #879
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

I've been running this in offline mode and in locations with slow/spotty internet. Sometimes this means the CLI crashes after a few seconds. It'd be nice to be able to run with --offline to stop network calls from happening.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 22, 2023
This was referenced Sep 22, 2023
Merged
Closed
JoshuaKGoldberg added a commit that referenced this issue Sep 29, 2023
@JoshuaKGoldberg
feat: add --offline mode (#879)
715e79d 
## PR Checklist

- [x] Addresses an existing open issue: fixes #878
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds `--offline` flag that skips running scripts. That includes a
timeout for `npm whoami`, as I've found that command to hang when I'm on
an airplane.

Also corrects a bit of the logic around adding the user as a
contributor, while I'm in the area. And fixes up unit tests around that.
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Post-Rename Migration
Development

Successfully merging a pull request may close this issue.

feat: add --offline mode JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg