Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: test.yml doesn't get created by default #909

Closed
3 tasks done
JoshuaKGoldberg opened this issue Oct 1, 2023 · 3 comments · Fixed by #910
Closed
3 tasks done

🐛 Bug: test.yml doesn't get created by default #909

JoshuaKGoldberg opened this issue Oct 1, 2023 · 3 comments · Fixed by #910
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Oct 1, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Unless --exclude-tests is specified, test.yml should be created in new repos.

Actual

It isn't.

Additional Info

Reported by @KATT in #907 (comment).
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Oct 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Oct 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Oct 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 1, 2023
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Owner Author

@allcontributors add @KATT for bug

@allcontributors allcontributors bot mentioned this issue Oct 1, 2023
Merged
@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @KATT! 🎉

JoshuaKGoldberg added a commit that referenced this issue Oct 1, 2023
@JoshuaKGoldberg
fix: invert test.yml excludes logic (#910)
bbb6760 
## PR Checklist

- [x] Addresses an existing open issue: fixes #909
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

🤦 .
JoshuaKGoldberg pushed a commit that referenced this issue Oct 1, 2023
@allcontributors
docs: add katt as a contributor for bug (#911)
aeebdd5 
Adds @KATT as a contributor for bug.

This was requested by JoshuaKGoldberg [in this
comment](#909 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Post-Rename Migration
Development

Successfully merging a pull request may close this issue.

fix: invert test.yml excludes logic JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg