Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Generated ESLint config hardcodes n/no-missing-import's allowedModules #923

Closed
3 tasks done
JoshuaKGoldberg opened this issue Oct 1, 2023 · 1 comment · Fixed by #924
Closed
3 tasks done

🐛 Bug: Generated ESLint config hardcodes n/no-missing-import's allowedModules #923

JoshuaKGoldberg opened this issue Oct 1, 2023 · 1 comment · Fixed by #924
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Running pnpm lint on a newly created repository with --base everything should pass.

Actual

https://github.com/JoshuaKGoldberg/release-it-action/actions/runs/6372114984/job/17294648796

/home/runner/work/release-it-action/release-it-action/README.md
Error:   34:23  error  "release-it-action" is not found  n/no-missing-import

Additional Info

create-typescript-app/src/steps/writing/creation/createESLintRC.ts

Line 85 in ddf1318

{ allowModules: ["create-typescript-app"] },

@JoshuaKGoldberg JoshuaKGoldberg added the type: bug Something isn't working :( label Oct 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Oct 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Oct 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Oct 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 1, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Oct 1, 2023
@JoshuaKGoldberg
fix: use options.repository for n/no-missing-import's allowedModules (#…
0b542be 
…924)

## PR Checklist

- [x] Addresses an existing open issue: fixes #923
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Instead of hardcoding the one allowed module name to
`create-typescript-app`, uses `options.repository`.
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Post-Rename Migration
1 participant
@JoshuaKGoldberg