Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Git tags should be cleared after creating a new repository #926

Closed
3 tasks done
JoshuaKGoldberg opened this issue Oct 2, 2023 · 1 comment · Fixed by #1614
Closed
3 tasks done

🐛 Bug: Git tags should be cleared after creating a new repository #926

JoshuaKGoldberg opened this issue Oct 2, 2023 · 1 comment · Fixed by #1614
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

When a new repository is created (--mode create), it should have no Git tags to start.

Actual

...instead, they have the full list of git tags from this JoshuaKGoldberg/create-typescript-app repo 😂. Example from https://github.com/JoshuaKGoldberg/release-it-action:

~/repos/release-it-action $ git tag --list 
v0.1.0
v0.1.1
v0.2.0
v0.2.1
v1.0.0
v1.1.0
v1.1.1
v1.1.2
...

Additional Info

Tags are auto-created by https://github.com/release-it/release-it during publishing (.github/workflows/release.yml). So it's good that a repo can create them. But they shouldn't be copied from the template to a new repository.

https://stackoverflow.com/questions/19542301/delete-all-tags-from-a-git-repository
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Oct 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 11, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Aug 11, 2024
@JoshuaKGoldberg
fix: delete any existing Git tags in --mode create (#1614)
95cebe1 
## PR Checklist

- [x] Addresses an existing open issue: fixes #926
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

At the end of `createWithOptions`, prepends a nice little Git command
before the other commands. Includes a small refactor of
`createCleanupCommands` to not care about the mode.

💖
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.67.4 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: delete any existing Git tags in --mode create JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg