Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: .all-contributorsrc template is missing an emoji in its alt text #929

Closed
3 tasks done
JoshuaKGoldberg opened this issue Oct 2, 2023 · 1 comment · Fixed by #930
Closed
3 tasks done

🐛 Bug: .all-contributorsrc template is missing an emoji in its alt text #929

JoshuaKGoldberg opened this issue Oct 2, 2023 · 1 comment · Fixed by #930
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

<img alt="All Contributors: 30 🤝" src="https://img.shields.io/badge/all_contributors-30_🤝-21bb42.svg" />

Actual

<img alt="All Contributors: 30" src="https://img.shields.io/badge/all_contributors-30_🤝-21bb42.svg" />

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Oct 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Oct 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Oct 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🐛 Bug: .all-contributorsrc template is missing an emoji 🐛 Bug: .all-contributorsrc template is missing an emoji in its alt text Oct 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 2, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Oct 2, 2023
@JoshuaKGoldberg
fix: set emoji for all-contributors badge to 👪 (#930)
dc67d1f 
## PR Checklist

- [x] Addresses an existing open issue: fixes #929
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

I realized the 🤝 emoji is already used for the code of conduct badge.
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Post-Rename Migration
Development

Successfully merging a pull request may close this issue.

fix: set emoji for all-contributors badge to 👪 JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg