Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Run a build, ignoring status codes, before lint in CI #935

Closed
3 tasks done
JoshuaKGoldberg opened this issue Oct 2, 2023 · 1 comment · Fixed by #936
Closed
3 tasks done

🚀 Feature: Run a build, ignoring status codes, before lint in CI #935

JoshuaKGoldberg opened this issue Oct 2, 2023 · 1 comment · Fixed by #936
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

I'm finding that many templated packages need to run pnpm build || true before pnpm lint in CI. This is because code snippets and bin/ files sometimes refer to built files, such as lib/index.js.

This should be documented too.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Oct 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 2, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Oct 2, 2023
@JoshuaKGoldberg
feat: always run build || exit 0 before lint in CI (#936)
827b4b4 
## PR Checklist

- [x] Addresses an existing open issue: fixes #935
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds `pnpm build || true` before `pnpm lint` in the templated
`lint.yml`. That's what this repo already does, so this essentially
makes templated repos more like this one.
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.34.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: always run build || exit 0 before lint in CI JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg