Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Bump .nvmrc Node version to 20 #953

Closed
3 tasks done
JoshuaKGoldberg opened this issue Oct 11, 2023 · 1 comment · Fixed by #957
Closed
3 tasks done

🚀 Feature: Bump .nvmrc Node version to 20 #953

JoshuaKGoldberg opened this issue Oct 11, 2023 · 1 comment · Fixed by #957
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

create-typescript-app/.nvmrc

Line 1 in 3e7ac59

18.18.0

Node 20 is in the active support window and Node 18 is about to enter maintenance mode: https://nodejs.dev/en/about/releases. There's no real reason why this nice modern repo needs to be behind. Let's bump to the latest Node 20.x version!

Additional Info

The templating for .nvmrc will need to be updated too:

create-typescript-app/src/steps/writing/creation/rootFiles.ts

Line 49 in 3e7ac59

".nvmrc": `18.18.0\n`,

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Oct 11, 2023
@biplobsd biplobsd mentioned this issue Oct 12, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Oct 14, 2023
@biplobsd @JoshuaKGoldberg
feat: updated Node version to 20.8.0 (#957)
981ad21 
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #953
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

I updated the .nvmrc version to 20.8.0 as described in the issues.

Co-authored-by: Josh Goldberg <[email protected]>
@github-actions
Copy link

🎉 This is included in version v1.38.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: updated Node version to 20.8.0 biplobsd/create-typescript-app
1 participant
@JoshuaKGoldberg