Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated Node version to 20.8.0 #957

Merged
merged 2 commits into from
Oct 14, 2023
Merged

feat: updated Node version to 20.8.0 #957

merged 2 commits into from
Oct 14, 2023

Conversation

biplobsd
Copy link
Contributor

PR Checklist

Overview

I updated the .nvmrc version to 20.8.0 as described in the issues.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell, thanks!

Just a heads up - PR titles need to adhere to a conventional commits standard. It's a small change, so I went ahead and applied here.

@JoshuaKGoldberg JoshuaKGoldberg changed the title Updated Node version to 20.8.0 (#953) feat: updated Node version to 20.8.0 (#953) Oct 14, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: updated Node version to 20.8.0 (#953) feat: updated Node version to 20.8.0 Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #957 (47f6e26) into main (2e3a497) will increase coverage by 12.19%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #957       +/-   ##
===========================================
+ Coverage   81.27%   93.47%   +12.19%     
===========================================
  Files          86       91        +5     
  Lines        4727     4860      +133     
  Branches      225      403      +178     
===========================================
+ Hits         3842     4543      +701     
+ Misses        880      316      -564     
+ Partials        5        1        -4
Flag Coverage Δ
create 71.10% <100.00%> (ø)
initialize 38.29% <0.00%> (ø)
migrate 69.95% <100.00%> (ø)
unit 68.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/steps/writing/creation/rootFiles.ts 96.63% <100.00%> (ø)

... and 48 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 981ad21 into JoshuaKGoldberg:main Oct 14, 2023
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @biplobsd for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Oct 14, 2023
Merged
@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @biplobsd! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@github-actions
Copy link

🎉 This is included in version v1.38.0 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request Oct 14, 2023
@allcontributors
docs: add biplobsd as a contributor for code (#962)
b95e1b9 
Adds @biplobsd as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#957 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@biplobsd
Copy link
Contributor Author

biplobsd commented Nov 5, 2023

https://biplobsd.me/blogs/view/contributing-to-open-source-my-hacktoberfest-experience.md

I wrote a blog about my hacktoberfest journey. I mentioned @JoshuaKGoldberg on my blog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Bump .nvmrc Node version to 20
2 participants
@biplobsd @JoshuaKGoldberg