Skip to content

chore: remove unnecessary if in a11y-alt-bot #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DerTimonius
Copy link
Contributor

PR Checklist

Overview

This PR is hopefully the last one in the series of getting the accessibility-alt-text-bot correct by removing the unnecessary if statement in the yml job

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #1009 (30b289d) into main (d43b967) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
- Coverage   93.64%   93.64%   -0.01%     
==========================================
  Files          93       93              
  Lines        4992     4991       -1     
  Branches      420      420              
==========================================
- Hits         4675     4674       -1     
  Misses        316      316              
  Partials        1        1              
Flag Coverage Δ
create 70.87% <ø> (-0.01%) ⬇️
initialize 38.35% <ø> (+<0.01%) ⬆️
migrate 69.75% <ø> (-0.01%) ⬇️
unit 68.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...teps/writing/creation/dotGitHub/createWorkflows.ts 99.14% <ø> (-0.01%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 69af9ec into JoshuaKGoldberg:main Nov 5, 2023
Copy link

github-actions bot commented Nov 8, 2023

🎉 This is included in version v1.43.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Is the 'if' in the accessibility-alt-text-bot workflow is needed?
2 participants