-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: overhaul for scripts and their end-to-end tests #1187
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
+ Coverage 94.61% 94.68% +0.07%
==========================================
Files 99 102 +3
Lines 5666 5685 +19
Branches 466 466
==========================================
+ Hits 5361 5383 +22
+ Misses 304 301 -3
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Okie dokie, thanks for the suggestions! I'm going to merge this now to get the docs improvements in. If there are more suggestions you'd want to make feel free to file an issue or just send a PR (either or both, whatever's easier for you). These things are tricky 😄 |
@all-contributors please add @gmail.com> for doc.
|
Could not find the user |
Hmm. That should have been fixed by JoshuaKGoldberg/all-contributors-for-repository#88 -> JoshuaKGoldberg/all-contributors-for-repository#89. Filed a new issue: JoshuaKGoldberg/all-contributors-for-repository#199 |
🎉 This is included in version v1.52.7 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
Adds some inline comments to end-to-end tests, as well as a more full description of what to do with migration snapshots in development docs. Also simplifies the migration test error to suggest looking at the docs.
Touches a little bit on what #1045 requests around more clear and standardized token docs.
Co-authored-by: John Reilly [email protected]
Co-authored-by: Mohammad Bagher Abiyat [email protected]