-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: rimraf coverage directories in --mode migrate #1248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1248 +/- ##
==========================================
- Coverage 94.82% 94.81% -0.01%
==========================================
Files 104 104
Lines 5815 5804 -11
Branches 491 492 +1
==========================================
- Hits 5514 5503 -11
Misses 300 300
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@all-contributors please add @NanderTGA for code.
|
I've put up a pull request to add @NanderTGA! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
🎉 This is included in version v1.54.0 🎉 The release is available on: Cheers! 📦🚀 |
Adds @NanderTGA as a contributor for code. This was requested by JoshuaKGoldberg [in this comment](#1248 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
PR Checklist
status: accepting prs
Overview
Cleans
coverage*
directories as a part of--mode migrate
so that format and lint runs don't take forever going through them.Also cleans the directories at the beginning of all three end-to-end test formats. Sometimes I run them locally and it's a pain to have forgotten to clear the coverage directories in that case.
Thanks to @NanderTGA for suggesting using
rimraf
for Windows support. I would have used the *nix-onlyrm -rf
by myself. 😄Co-authored-by: @NanderTGA