Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use --no-dts in cleanup and pre-lint builds #1255

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Uses the lovely, newly-discovered-by-me --no-dts option. Now the builds done before CI linting (when options.bin is enabled) and in the cleanup commands should be much faster.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98c7675) 94.81% compared to head (e341ac8) 94.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1255   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files         104      104           
  Lines        5807     5807           
  Branches      492      492           
=======================================
  Hits         5506     5506           
  Misses        300      300           
  Partials        1        1           
Flag Coverage Δ
create 70.09% <0.00%> (ø)
initialize 42.24% <0.00%> (ø)
migrate 69.90% <0.00%> (ø)
unit 75.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg
Copy link
Owner Author

/home/runner/work/create-typescript-app/create-typescript-app/create-typescript-app/tsconfig.json
Error:   14:21  error  Unexpected trailing comma  jsonc/comma-dangle
Error:   16:20  error  Unexpected trailing comma  jsonc/comma-dangle

😭. I can't win with that darn rule. Will need to investigate why it's suddenly enabled so strongly...

@JoshuaKGoldberg JoshuaKGoldberg merged commit 0fffae0 into main Jan 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the pnpm-build-no-dts branch January 17, 2024 05:10
Copy link

🎉 This is included in version v1.54.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Skip dts generation in lint.yml's build
1 participant