Skip to content

fix: pin zod-validation-error version to 3.0.0 #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

DemianParkhomenko
Copy link
Contributor

@DemianParkhomenko DemianParkhomenko commented Feb 13, 2024

PR Checklist

Overview

Recent update of zod-validation-error breaks create-typescript-app: causaly/zod-validation-error#253

Screen.Recording.2024-02-13.at.02.04.06.mov

👀

@DemianParkhomenko DemianParkhomenko marked this pull request as ready for review February 13, 2024 00:20
@DemianParkhomenko DemianParkhomenko changed the title Pin zod-validation-error version to 3.0.0 fix: pin zod-validation-error version to 3.0.0 Feb 13, 2024
@thanoskrg
Copy link

Hi @DemianParkhomenko, FYI we've reverted the change that was causing the issue, so we can investigate.

https://github.com/causaly/zod-validation-error/releases/tag/v3.0.2

@JoshuaKGoldberg
Copy link
Owner

Yup, looks like this should be a pin to 3.0.2 now. Up for updating @DemianParkhomenko? 🙂

Thanks for reporting btw!

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ea1c18) 94.79% compared to head (2861a13) 94.78%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
- Coverage   94.79%   94.78%   -0.01%     
==========================================
  Files         103      103              
  Lines        5781     5776       -5     
  Branches      490      488       -2     
==========================================
- Hits         5480     5475       -5     
  Misses        300      300              
  Partials        1        1              
Flag Coverage Δ
create 69.94% <ø> (+<0.01%) ⬆️
initialize 42.44% <ø> (+0.03%) ⬆️
migrate 69.86% <ø> (+0.02%) ⬆️
unit 75.64% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DemianParkhomenko
Copy link
Contributor Author

Yup, looks like this should be a pin to 3.0.2 now. Up for updating @DemianParkhomenko? 🙂

Thanks for reporting btw!

Should it be ^3.0.2 or 3.0.2?

@JoshuaKGoldberg
Copy link
Owner

Let's go with ^3.0.2. Now that the bug is fixed there's no need to restrict to the specific number.

zod: ^3.18.0
dependencies:
zod: 3.22.4
dev: false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that Knip has 3.0.0 exactly. Once they bump this duplication will go away.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 275784d into JoshuaKGoldberg:main Feb 13, 2024
Copy link

🎉 This is included in version v1.57.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants