-
-
Notifications
You must be signed in to change notification settings - Fork 80
fix: pin zod-validation-error version to 3.0.0 #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @DemianParkhomenko, FYI we've reverted the change that was causing the issue, so we can investigate. https://github.com/causaly/zod-validation-error/releases/tag/v3.0.2 |
Yup, looks like this should be a pin to 3.0.2 now. Up for updating @DemianParkhomenko? 🙂 Thanks for reporting btw! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
- Coverage 94.79% 94.78% -0.01%
==========================================
Files 103 103
Lines 5781 5776 -5
Branches 490 488 -2
==========================================
- Hits 5480 5475 -5
Misses 300 300
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Should it be |
Let's go with |
zod: ^3.18.0 | ||
dependencies: | ||
zod: 3.22.4 | ||
dev: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that Knip has 3.0.0
exactly. Once they bump this duplication will go away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🎉 This is included in version v1.57.2 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
Recent update of zod-validation-error breaks create-typescript-app: causaly/zod-validation-error#253
Screen.Recording.2024-02-13.at.02.04.06.mov
👀