Skip to content

test: finish unit testing initialize and initializeWithOptions #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 15, 2024

PR Checklist

Overview

As the issue suggested, this was a fair bit of setup. But I feel better now.

Also swaps out a 0 that was just coincidentally the same as the proper StatusCodes.Success.

💖

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 61e374f into main Aug 15, 2024
13 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the initialize-tests branch August 15, 2024 02:51
Copy link

🎉 This is included in version v1.71.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧪 Testing: Fill in unit test coverage for initializeWithOptions.ts
1 participant