feat: remove now-unnecessary disable of jsdoc/lines-before-block

eslint.config.js

@@ -64,9 +64,6 @@ export default tseslint.config(
 			},
 		},
 		rules: {
-			// These on-by-default rules don't work well for this repo and we like them off.
-			"jsdoc/lines-before-block": "off",
-
 			// These on-by-default rules work well for this repo if configured
 			"@typescript-eslint/no-unnecessary-condition": [
 				"error",

package.json

@@ -77,7 +77,7 @@
 		"console-fail-test": "^0.5.0",
 		"cspell": "^8.14.2",
 		"eslint": "^9.9.0",
-		"eslint-plugin-jsdoc": "^50.5.0",
+		"eslint-plugin-jsdoc": "^50.6.0",
 		"eslint-plugin-jsonc": "^2.16.0",
 		"eslint-plugin-markdown": "^5.1.0",
 		"eslint-plugin-n": "^17.12.0",

script/__snapshots__/migrate-test-e2e.ts.snap

@@ -134,10 +134,8 @@ exports[`expected file changes > eslint.config.js 1`] = `
  				},
  				tsconfigRootDir: import.meta.dirname,
  			},
-@@ ... @@ export default tseslint.config(
- 			// These on-by-default rules don't work well for this repo and we like them off.
- 			"jsdoc/lines-before-block": "off",
-
+ 		},
+ 		rules: {
 -			// These on-by-default rules work well for this repo if configured
 -			"@typescript-eslint/no-unnecessary-condition": [
 -				"error",

src/steps/writing/creation/createESLintConfig.test.ts

@@ -148,9 +148,6 @@ describe("createESLintConfig", () => {
 				      },
 				    },
 				    rules: {
-				      // These on-by-default rules don't work well for this repo and we like them off.
-				      "jsdoc/lines-before-block": "off",
-
 				      // Stylistic concerns that don't interfere with Prettier
 				      "logical-assignment-operators": [
 				        "error",

src/steps/writing/creation/createESLintConfig.ts

@@ -42,19 +42,9 @@ export async function createESLintConfig(options: Options) {
 		!options.excludeLintRegex && `	regexp.configs["flat/recommended"],`,
 	].filter(Boolean);
 
-	const rules = `{
-			${
-				options.excludeLintJSDoc
-					? ""
-					: `
-
-			// These on-by-default rules don't work well for this repo and we like them off.
-			"jsdoc/lines-before-block": "off",`
-			}${
-				options.excludeLintStylistic
-					? ""
-					: `
-
+	const rules =
+		!options.excludeLintStylistic &&
+		`{
 			// Stylistic concerns that don't interfere with Prettier
 			"logical-assignment-operators": [
 				"error",
@@ -63,8 +53,7 @@ export async function createESLintConfig(options: Options) {
 			],
 			"no-useless-rename": "error",
 			"object-shorthand": "error",
-			"operator-assignment": "error",`
-			}
+			"operator-assignment": "error",
 		}`;
 
 	return await formatTypeScript(`${imports.join("\n")}
@@ -111,10 +100,10 @@ export default tseslint.config(
 				tsconfigRootDir: import.meta.dirname
 			},
 		},${
-			rules.replaceAll(/\s+/g, "") === "{}"
-				? ""
-				: `
+			rules
+				? `
 		rules: ${rules},`
+				: ""
 		}${
 			options.excludeLintPerfectionist
 				? ""