Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: post release permissions error #1750

Merged
merged 6 commits into from
Dec 7, 2024
Merged

fix: post release permissions error #1750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
31d3415
fix: permissions for post-release.yml
johnnyreilly Dec 7, 2024
9d57bda
fix: tests
johnnyreilly Dec 7, 2024
60155a8
fix: lint
johnnyreilly Dec 7, 2024
33d02a3
fix: lint
johnnyreilly Dec 7, 2024
871da1f
fix: permissions for post-release.yml
johnnyreilly Dec 7, 2024
dd8f0dc
fix: tests
johnnyreilly Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/post-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,7 @@ on:
release:
types:
- published

permissions:
issues: write
pull-requests: write
4 changes: 4 additions & 0 deletions src/next/blocks/blockReleaseIt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ export const blockReleaseIt = base.createBlock({
types: ["published"],
},
},
permissions: {
issues: "write",
"pull-requests": "write",
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁 I do think it kind of painfully funny that in attempting to remove one annoying end-to-end test (script/migrate-test-e2e.test.ts) I'm temporarily giving you another probably annoying extra bit of work... thanks for tolerating it and also contributing to the new block engine!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"painfully funny" is accurate!

I've come to regard the automated tests of CTA as developer hostile end-of-level baddies. If I was into darts I'd print out one of the failed test runs and pin it to the board 😅

steps: [
{ uses: "actions/checkout@v4", with: { "fetch-depth": 0 } },
{
Expand Down
4 changes: 4 additions & 0 deletions src/steps/writing/creation/dotGitHub/createWorkflows.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,10 @@ describe("createWorkflows", () => {
release:
types:
- published

permissions:
issues: write
pull-requests: write
",
"pr-review-requested.yml": "jobs:
pr_review_requested:
Expand Down
4 changes: 4 additions & 0 deletions src/steps/writing/creation/dotGitHub/createWorkflows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,10 @@ export function createWorkflows(options: Options) {
types: ["published"],
},
},
permissions: {
issues: "write",
"pull-requests": "write",
},
steps: [
{ uses: "actions/checkout@v4", with: { "fetch-depth": 0 } },
{
Expand Down
Loading