chore: bring in updates for create's interactive CLI #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Dec 19, 2024
JoshuaKGoldberg
commented
Dec 19, 2024
src/next/inputs/inputFromScript.ts
Outdated
There was a problem hiding this comment.
TODO: I'll split this out into its own first-party create package.
JoshuaKGoldberg
commented
Dec 19, 2024
| @@ -14,7 +14,6 @@ export const blockRepositorySettings = base.createBlock({ | |||
| allow_auto_merge: true, | |||
| allow_rebase_merge: false, | |||
| allow_squash_merge: true, | |||
| default_branch: "main", | |||
There was a problem hiding this comment.
This is the only part of the API that can't run on an empty repository at the moment. I don't mind removing it for now to simplify things. The new default branch in repositories is main now for a while anyway.
2 tasks
JoshuaKGoldberg
commented
Dec 20, 2024
JoshuaKGoldberg
commented
Dec 20, 2024
JoshuaKGoldberg
commented
Dec 22, 2024
src/steps/finalizeDependencies.ts
Outdated
| "-D", | ||
| ); | ||
| } | ||
|
|
||
| await execaCommand(`pnpm dedupe --offline`); |
There was a problem hiding this comment.
I don't know why these errors are happening in CI 😞:
\u2009ERR_PNPM_NO_OFFLINE_META\u2009 Failed to resolve @types/[email protected] in package mirror /home/runner/.cache/pnpm/metadata-v1.3/registry.npmjs.org/@types/git-url-parse.json
There was a problem hiding this comment.
Aha!
> husky
.git can't be found
It's that whatever is running scripts is probably not working in the right directory. Ha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Applies three main areas of change:
directorystring for option defaults so they can work outside of the cwdgh config get user -h gb.xjqchip.workers.devforoptions.owner, finally removing the need to manually re-type your own owner always 🥳.describe("...")to their Zod schemas so they can be nicely described in prompts (and, eventually, auto-generated docs)suggestionsIndirect Creations to generate the nice "be sure to..." notice upon completionAlso removes the
--offlinefromfinalizeDependencies.💖