Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pnpx, not npx #1800

Merged
merged 2 commits into from
Dec 24, 2024
Merged

fix: use pnpx, not npx #1800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d08af37
fix: use pnpx, not npx
JoshuaKGoldberg Dec 24, 2024
9069688
no -y
JoshuaKGoldberg Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/next/blocks/blockAllContributors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ describe("blockAllContributors", () => {
"scripts": [
{
"commands": [
"npx -y all-contributors-cli generate",
"npx -y all-contributors-cli add test-owner code,content,docs,ideas,infra,maintenance,projectManagement,tool",
"pnpx all-contributors-cli generate",
"pnpx all-contributors-cli add test-owner code,content,docs,ideas,infra,maintenance,projectManagement,tool",
],
"phase": 3,
},
Expand Down Expand Up @@ -138,8 +138,8 @@ describe("blockAllContributors", () => {
"scripts": [
{
"commands": [
"npx -y all-contributors-cli generate",
"npx -y all-contributors-cli add test-owner code,content,docs,ideas,infra,maintenance,projectManagement,tool",
"pnpx all-contributors-cli generate",
"pnpx all-contributors-cli add test-owner code,content,docs,ideas,infra,maintenance,projectManagement,tool",
],
"phase": 3,
},
Expand Down
4 changes: 2 additions & 2 deletions src/next/blocks/blockAllContributors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ export const blockAllContributors = base.createBlock({
scripts: [
{
commands: [
`npx -y all-contributors-cli generate`,
`npx -y all-contributors-cli add ${options.owner} code,content,docs,ideas,infra,maintenance,projectManagement,tool`,
`pnpx all-contributors-cli generate`,
`pnpx all-contributors-cli add ${options.owner} code,content,docs,ideas,infra,maintenance,projectManagement,tool`,
],
phase: CommandPhase.Process,
},
Expand Down
4 changes: 2 additions & 2 deletions src/shared/getGitHubUserAsAllContributor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe("getGitHubUserAsAllContributor", () => {
[
[
[
"npx -y [email protected] add ",
"pnpx [email protected] add ",
" ",
"",
],
Expand All @@ -90,7 +90,7 @@ describe("getGitHubUserAsAllContributor", () => {
[
[
[
"npx -y [email protected] add ",
"pnpx [email protected] add ",
" ",
"",
],
Expand Down
2 changes: 1 addition & 1 deletion src/shared/getGitHubUserAsAllContributor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export async function getGitHubUserAsAllContributor(
"projectManagement",
"tool",
].join(",");
await $`npx -y [email protected] add ${user} ${contributions}`;
await $`pnpx [email protected] add ${user} ${contributions}`;

return user;
}
2 changes: 1 addition & 1 deletion src/steps/addToolAllContributors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe("addToolAllContributors", () => {
await addToolAllContributors(undefined, { owner: "owner" });

expect(mock$).toHaveBeenCalledWith([
`npx -y all-contributors-cli add JoshuaKGoldberg tool`,
`pnpx all-contributors-cli add JoshuaKGoldberg tool`,
]);
});
});
2 changes: 1 addition & 1 deletion src/steps/addToolAllContributors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ export async function addToolAllContributors(
const login = await getGitHubUserAsAllContributor(octokit, options);

if (login !== "JoshuaKGoldberg") {
await $`npx -y all-contributors-cli add JoshuaKGoldberg tool`;
await $`pnpx all-contributors-cli add JoshuaKGoldberg tool`;
}
}
2 changes: 1 addition & 1 deletion src/steps/updateAllContributorsTable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ export async function updateAllContributorsTable({
}),
);

await $`npx -y all-contributors-cli generate`;
await $`pnpx all-contributors-cli generate`;
}
Loading