Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade knip & config #1898

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

webpro
Copy link
Contributor

@webpro webpro commented Jan 17, 2025

PR Checklist

Overview

Saw that remove-dependencies caused the knip lint task to fail in this repo, which made me see and fix the issue with "all-contributors-cli" and wrap things up here :)

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, yeah, things are a little chaotic right now. I've been wrestling #1839 into submission and neglecting the main branch as a result. Thanks for the cleanup!

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review January 17, 2025 14:05
@JoshuaKGoldberg JoshuaKGoldberg merged commit d46dd40 into JoshuaKGoldberg:main Jan 17, 2025
7 of 15 checks passed
@webpro webpro deleted the upgrade-knip branch January 17, 2025 14:58
@webpro
Copy link
Contributor Author

webpro commented Jan 17, 2025

Cool! Fun fact: one thing led to another and more execa usage patterns are supported now in Knip too: https://github.com/webpro-nl/knip/blob/main/packages/knip/fixtures/script-visitors/execa/methods.mjs (i.e. the executable* are recognized as binary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants