fix: update existing ruleset when in transition mode #1951
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
Previously,
blockRepositoryBranchRuleset
would always create a ruleset onmain
with the hardcoded name. This is fine for setup mode but crashes on a duplicate ID creation error in transition mode.Now, its creations are split between the two modes:
POST
creates the ruleset as beforePUT
updates the existing rulesetThe
PUT
update requires aruleset_id
, so I added that as a new option in the Base populated by a newinputFromOctkit
.🎁