Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't crash if GitHub API call for rulesetId option fails #1953

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

A nice exercise of the input testers.

🎁

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.43%. Comparing base (d2fc614) to head (64ffab6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1953   +/-   ##
=======================================
  Coverage   95.42%   95.43%           
=======================================
  Files          87       87           
  Lines        3586     3590    +4     
  Branches      205      207    +2     
=======================================
+ Hits         3422     3426    +4     
  Misses        164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit c04bb29 into main Mar 4, 2025
14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the input-from-github-undefined-if-error branch March 4, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Crashes in setup mode for non-existing ruleset_id fetch
1 participant