Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include URLs in GitHub app and secret suggestions #1964

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Refactors the two blocks to use a shared getInstallationSuggestions function because I didn't want to keep updating both.

🎁

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2793e4c into main Mar 6, 2025
12 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the github-suggestions-include-url branch March 6, 2025 16:05
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.55%. Comparing base (92ef8c8) to head (774a865).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
+ Coverage   95.48%   95.55%   +0.06%     
==========================================
  Files          90       91       +1     
  Lines        3635     3643       +8     
  Branches      214      214              
==========================================
+ Hits         3471     3481      +10     
+ Misses        164      162       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Mar 6, 2025

🎉 This is included in version v2.4.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: "enable the GitHub apps" / "populate the secrets" to include links to the relevant URLs
1 participant