Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more permissive usage bounds and headings #2042

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 27, 2025

PR Checklist

Overview

Makes options.usage parsing more permissive in two ways:

  • Instead of only searching for a second heading under ## Development, also allows ## Contributing and ## Contributors
  • If that second heading isn't found then the rest of the README.md is returned instead of undefined

The fixed behavior can be seen in JoshuaKGoldberg/cspell-populate-words@736e48b.

🎁

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2b57403 into main Mar 27, 2025
14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the more-flexible-usage branch March 27, 2025 14:43
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.81%. Comparing base (5f58fb2) to head (bd9c686).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2042      +/-   ##
==========================================
- Coverage   99.81%   99.81%   -0.01%     
==========================================
  Files         118      118              
  Lines        4919     4916       -3     
  Branches      305      305              
==========================================
- Hits         4910     4907       -3     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

🎉 This is included in version v2.15.6 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: options.usage reading removes existing contents in some repositories
1 participant