Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize yaml outputs to always use -1 lineWidth #2098

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 2, 2025

PR Checklist

Overview

Whatever reason I had for having two different calls to jsYaml.dump is, I think, no longer there. This normalizes all YAML printing to go through the standard formatYaml. YAML files now always have a blank line between root-level properties.

🎁

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@JoshuaKGoldberg JoshuaKGoldberg changed the title 'fix: normalize yaml outputs to always use -1 lineWidth fix: normalize yaml outputs to always use -1 lineWidth Apr 2, 2025
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (25e9a51) to head (f1cddef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2098   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         127      126    -1     
  Lines        5185     5185           
  Branches      357      357           
=======================================
  Hits         5176     5176           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg merged commit f64dba4 into main Apr 2, 2025
13 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the yaml-normalized branch April 2, 2025 16:29
Copy link

github-actions bot commented Apr 2, 2025

🎉 This is included in version v2.22.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Long YAML uses with # comment gets printed as multiline string
1 participant