Skip to content

feat: use eslint-plugin-perfectionist #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 12, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 12, 2023

PR Checklist

Overview

I am a perfectionist. It's a match made in heaven!

Swaps from the much more targeted eslint-plugin-simple-import-sort and eslint-plugin-typescript-sort-keys to eslint-plugin-perfectionist.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #527 (03964b2) into main (4236404) will decrease coverage by 0.14%.
The diff coverage is 94.44%.

❗ Current head 03964b2 differs from pull request most recent head 2606cd2. Consider uploading reports for the commit 2606cd2 to get more accurate results

@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
- Coverage   68.92%   68.79%   -0.14%     
==========================================
  Files          55       55              
  Lines        1181     1176       -5     
  Branches       90       90              
==========================================
- Hits          814      809       -5     
  Misses        361      361              
  Partials        6        6              
Impacted Files Coverage Δ
src/hydrate/hydrate.ts 0.00% <ø> (ø)
src/hydrate/steps/finalizeDependencies.ts 100.00% <ø> (ø)
...s/writing/creation/dotGitHub/createWorkflowFile.ts 75.00% <ø> (ø)
...te/steps/writing/creation/formatters/formatYaml.ts 60.00% <ø> (ø)
src/hydrate/steps/writing/creation/rootFiles.ts 0.00% <ø> (ø)
...hydrate/steps/writing/creation/writePackageJson.ts 100.00% <ø> (ø)
src/hydrate/steps/writing/writeStructureWorker.ts 88.23% <ø> (ø)
src/hydrate/values/getHydrationDefaults.ts 0.00% <ø> (ø)
src/hydrate/values/hydrationInputValues.ts 0.00% <ø> (ø)
src/setup/steps/clearChangelog.ts 100.00% <ø> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review June 12, 2023 20:15
@JoshuaKGoldberg JoshuaKGoldberg merged commit a6feabd into main Jun 12, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-plugin-perfectionist branch June 12, 2023 20:16
@github-actions
Copy link

🎉 This is included in version v1.28.13 🎉

The release is available on:

Cheers! 📦🚀

1 similar comment
@github-actions
Copy link

🎉 This is included in version v1.28.13 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Use an ESLint object literal keys sort rule
1 participant