Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add type:cleanup to outcomeLabels #635

Merged
merged 2 commits into from
Aug 14, 2023
Merged

feat: Add type:cleanup to outcomeLabels #635

merged 2 commits into from
Aug 14, 2023

Conversation

kristo-baricevic
Copy link
Contributor

@kristo-baricevic kristo-baricevic commented Aug 6, 2023

PR Checklist

Overview

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks @kristo-baricevic!

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, oops, looks like the Prettier check is failing. Could you run pnpm format --write locally?

https://github.com/JoshuaKGoldberg/template-typescript-node-package/actions/runs/5778671380/job/15662192533?pr=635

Run pnpm format --list-different

> [email protected] format /home/runner/work/template-typescript-node-package/template-typescript-node-package
> prettier "**/*" --ignore-unknown "--list-different"

src/setup/steps/labels/outcomeLabels.ts
 ELIFECYCLE  Command failed with exit code 1.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Aug 7, 2023
@github-actions github-actions bot removed the status: waiting for author Needs an action taken by the original poster label Aug 14, 2023
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 super, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 25ebb5b into JoshuaKGoldberg:main Aug 14, 2023
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @kristo-baricevic for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @kristo-baricevic! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@github-actions
Copy link

🎉 This is included in version v1.28.51 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg added a commit that referenced this pull request Aug 14, 2023
Adds @kristo-baricevic as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#635 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Josh Goldberg ✨ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add a type: cleanup label
2 participants