Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant format at end of finalizeDependencies #887

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: remove redundant format at end of finalizeDependencies #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/create/createWithOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ export async function createWithOptions({ github, options }: GitHubAndOptions) {

await runCommands("Cleaning up files", [
"pnpm dedupe",
"pnpm format --write",
"pnpm lint --fix",
"pnpm format --write",
]);

const sendToGitHub =
Expand Down
6 changes: 0 additions & 6 deletions src/steps/finalizeDependencies.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ describe("finalize", () => {
[
"npx all-contributors-cli generate",
],
[
"pnpm run format:write",
],
]
`);
});
Expand Down Expand Up @@ -94,9 +91,6 @@ describe("finalize", () => {
[
"pnpm add @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest eslint@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-jsdoc@latest eslint-plugin-n@latest eslint-plugin-regexp@latest husky@latest lint-staged@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest tsup@latest typescript@latest -D",
],
[
"pnpm run format:write",
],
]
`);
});
Expand Down
2 changes: 0 additions & 2 deletions src/steps/finalizeDependencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,4 @@ export async function finalizeDependencies(options: Options) {
"-D",
);
}

await execaCommand("pnpm run format:write");
}