Skip to content

add activate! function as alias to enable_in_core! #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

oscardssmith
Copy link
Member

@oscardssmith oscardssmith commented Apr 9, 2025

This will allow for automatic hookup to be done via InteractiveUtils.@activate JuliaSyntax.

TODO: On julia's end, we'll need to add JuliaSyntax to the components we're allowed to activate (and bump the JuliaSyntax version).

This will allow for automatic hookup to be done via `InteractiveUtils.@activate JuliaSyntax`.
@mlechu
Copy link
Member

mlechu commented Apr 11, 2025

(Experimental; do not merge)

Moved to [JuliaLowering](c42f/JuliaLowering.jl#10)
     instead (the data structure we need is defined there).
@oscardssmith
Copy link
Member Author

@mlechu now that the lowering parts of this are removed, is it ready for review/merge?

@c42f Any thoughts on this approach?

@mlechu
Copy link
Member

mlechu commented Apr 23, 2025

ready for review/merge?

Yup, should be good for review. I think the activate macro was modelled after our enable_in_core! anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants