Skip to content

use smaller matrix size in peakflops on 32-bit #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Conversation

JeffBezanson
Copy link
Member

This might help prevent failures like https://buildkite.com/julialang/julia-master/builds/46307#0195de97-a496-4daa-b71e-3124e3592505. Allocating several 128MB arrays on 32-bit certainly sounds like asking for an OOM.

@ViralBShah ViralBShah added backport 1.10 Change should be backported to the 1.10 release backport 1.12 Change should be backported to release-1.12 labels Apr 1, 2025
@ViralBShah
Copy link
Member

ViralBShah commented Apr 1, 2025

The actual tests seem to use 1024 so this shouldn't be causing a CI OOM. In any case, this is a good default for 32-bit systems.

https://github.com/JuliaLang/LinearAlgebra.jl/blob/master/test/generic.jl#L642

@ViralBShah
Copy link
Member

I see the actual issue comes from test/threads_exec.jl in the Julia tests that calls peakflops with no arguments. That test should probably also use 1024.

@ViralBShah ViralBShah merged commit e53b50c into master Apr 2, 2025
1 of 2 checks passed
@ViralBShah ViralBShah deleted the jb/peakflops32 branch April 2, 2025 05:31
@jishnub jishnub mentioned this pull request May 12, 2025
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.10 Change should be backported to the 1.10 release backport 1.12 Change should be backported to release-1.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants