Cleanup and generalize functions of Hermitian matrices #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
araujoms
changed the title
jishnub
reviewed
May 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
+ Coverage 93.75% 93.77% +0.02%
==========================================
Files 34 34
Lines 15778 15738 -40
==========================================
- Hits 14792 14758 -34
+ Misses 986 980 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@araujoms Can I invite you to have commit access to the repo (if you don't already have it)? |
|
Sure, that would be nice, thanks! (no, I don't have it) |
jishnub
reviewed
May 8, 2025
jishnub
reviewed
May 11, 2025
jishnub
reviewed
May 11, 2025
jishnub
approved these changes
May 13, 2025
jishnub
added a commit
that referenced
this pull request
May 13, 2025
…" (#1357) This reverts commit 611395d. Unfortunately, this PR introduced some method ambiguities that weren't caught by the CI, as the ambiguity test was broken. After the fix in #1349, this now causes test failures on master (https://buildkite.com/julialang/linearalgebra-dot-jl/builds/740#0196c86e-2d8c-42c2-b9ae-a2143427f43e). Please re-land the PR after fixing the ambiguities. CC: @araujoms
araujoms
added a commit
that referenced
this pull request
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly removes duplicated code. The only intentional change is to allow matrix functions to apply to any
Hermitianmatrix, as opposed to onlyHermitian{<:Complex}. This allows them to work for matrices of quaternions, for example.