Skip to content

Fix scaling unit triangular matrices #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented May 11, 2025

After this, the following works:

julia> U = UnitUpperTriangular(fill(SMatrix{2,2}([1 2; 3 4]), 2, 2))
2×2 UnitUpperTriangular{SMatrix{2, 2, Int64, 4}, Matrix{SMatrix{2, 2, Int64, 4}}}:
 [1 0; 0 1]  [1 2; 3 4]
            [1 0; 0 1]

julia> U * 2
2×2 UpperTriangular{SMatrix{2, 2, Int64, 4}, Matrix{SMatrix{2, 2, Int64, 4}}}:
 [2 0; 0 2]  [2 4; 6 8]
            [2 0; 0 2]

julia> U = UnitUpperTriangular(@SMatrix ones(4,4))
4×4 UnitUpperTriangular{Float64, SMatrix{4, 4, Float64, 16}} with indices SOneTo(4)×SOneTo(4):
 1.0  1.0  1.0  1.0
     1.0  1.0  1.0
         1.0  1.0
             1.0

julia> U * 2
4×4 UpperTriangular{Float64, MMatrix{4, 4, Float64, 16}} with indices SOneTo(4)×SOneTo(4):
 2.0  2.0  2.0  2.0
     2.0  2.0  2.0
         2.0  2.0
             2.0

@jishnub jishnub changed the title Fix scaling block unit triangular matrices Fix scaling unit triangular matrices May 11, 2025
Copy link

codecov bot commented May 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (ea8e858) to head (2148fa4).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1346      +/-   ##
==========================================
+ Coverage   93.75%   93.77%   +0.01%     
==========================================
  Files          34       34              
  Lines       15761    15752       -9     
==========================================
- Hits        14777    14771       -6     
+ Misses        984      981       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah ViralBShah added the backport 1.12 Change should be backported to release-1.12 label May 11, 2025
@ViralBShah ViralBShah merged commit 3393398 into master May 11, 2025
4 checks passed
@ViralBShah ViralBShah deleted the jishnub/unittri_scaling branch May 11, 2025 16:49
@jishnub jishnub mentioned this pull request May 12, 2025
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.12 Change should be backported to release-1.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants