Add the Kumaraswamy distribution #1699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
the
feature: new distribution
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1699 +/- ##
==========================================
- Coverage 85.89% 85.71% -0.19%
==========================================
Files 139 140 +1
Lines 8389 8455 +66
==========================================
+ Hits 7206 7247 +41
- Misses 1183 1208 +25
☔ View full report in Codecov by Sentry. |
|
Want to take a look at this, @devmotion? |
devmotion
reviewed
May 15, 2023
devmotion
reviewed
May 16, 2023
devmotion
reviewed
May 16, 2023
Some minor modifications made Co-Authored-By: David Widmann <[email protected]>
whoops
Co-Authored-By: David Widmann <[email protected]>
|
The failing integration tests with Tracker and ReverseDiff seem unrelated to this PR. |
|
Yeah, I'm not sure yet what's going on there. They failed on master as well but not in the last PR that was merged, and CI in DistributionsAD ran successfully just yesterday. So it might not even be related to a change in Distributions. |
devmotion
approved these changes
May 18, 2023
|
FYI the downstream tests fail due to FillArrays 1.0.1: JuliaArrays/FillArrays.jl#252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.