Improve performance #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optimized `readbytes!` method which copies data by chunks instead of byte per byte. Internally, avoid passing a `SubArray` to `readbytes!` as there is currently no optimized method for them: instead, wrap the corresponding memory in an `Array`. Increase the size of the buffer from 100 to 200 bytes, which appears to be a good tradeoff. This makes loading a file about 10 times faster than before.
nalimilan
commented
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optimized
readbytes!method which copies data by chunks instead of byte per byte.Internally, avoid passing a
SubArraytoreadbytes!as there is currently no optimized method for them: instead, wrap the corresponding memory in anArray.Increase the size of the buffer from 100 to 200 bytes, which appears to be a good tradeoff.
This makes loading a file about 10 times faster than before.
See also JuliaLang/julia#36607.