fix: revise filter for ISRC search and support Unicode #2614
+8
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehfd
force-pushed
the
isrc-fix
branch
2 times, most recently
from
eaef590 to
e2148e0
Compare
ehfd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @KRTirtho
It seems that the current filter for ISRC search is too strict. For example, when Spotify has the track title
Track - Single Version, and YouTube's ISRC title is namedTrack, the track gets filtered out.Instead of strictly filtering on the track title (relax to match just one word), inspired by #883 (comment), track duration is added as a filtering method.
This way, random search queries are not added to the track sources, and at the same time, queries that are supposed to be added are not filtered out.
Moreover, I've fixed the issue where the Unicode titles of tracks get filtered out.