Skip to content

Global strings showing as undefined #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Wutname1 opened this issue Mar 30, 2022 · 2 comments
Closed

Global strings showing as undefined #28

Wutname1 opened this issue Mar 30, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Wutname1
Copy link
Contributor

Most Global strings are not getting picked up as defined for me. I saw you were planning on adding them in #9 and there are some commits around it, did something get broken?

image
@Ketho
Copy link
Owner

Ketho commented Mar 30, 2022

The current behavior is that it only adds them to Lua.diagnostics.globals when completing code, it doesn't automatically pick up any existing globals so that has to be done manually. But I think it would be a nice improvement if it did, I should ask sumneko how that should be done.

@Ketho Ketho added the bug Something isn't working label Mar 30, 2022
@Arxareon Arxareon mentioned this issue Apr 29, 2022
Closed
@Ketho
Copy link
Owner

Ketho commented Jan 11, 2023

They should be automatically marked now in the v0.9.1 release

@Ketho Ketho closed this as completed Jan 11, 2023
Ketho added a commit that referenced this issue Jan 11, 2023
@Ketho
Update changelog (#28, #68)
69b0d9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wutname1 @Ketho