[DebugInfo] Fix CU translation when GV goes before CU #2010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translation of DebugInfo compilation units and entry points moved before translation of GVs. In other case we might end up in a situation when while quering for CUs we find none of them. Signed-off-by: Sidorov, Dmitry <[email protected]>
|
@vmaksimo @asudarsa @maksimsab @jgstarIntel @LU-JOHN please take a look |
maksimsab
approved these changes
May 19, 2023
MrSidims
added a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Jun 16, 2023
) Translation of DebugInfo compilation units and entry points moved before translation of GVs. In other case we might end up in a situation when while quering for CUs we find none of them. Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
added a commit
that referenced
this pull request
Jun 19, 2023
Translation of DebugInfo compilation units and entry points moved before translation of GVs. In other case we might end up in a situation when while quering for CUs we find none of them. Signed-off-by: Sidorov, Dmitry <[email protected]>
vmaksimo
pushed a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Jun 27, 2023
) Translation of DebugInfo compilation units and entry points moved before translation of GVs. In other case we might end up in a situation when while quering for CUs we find none of them. Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
added a commit
that referenced
this pull request
Jul 3, 2023
Translation of DebugInfo compilation units and entry points moved before translation of GVs. In other case we might end up in a situation when while quering for CUs we find none of them. Signed-off-by: Sidorov, Dmitry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation of DebugInfo compilation units and entry points moved before translation of GVs.
In other case we might end up in a situation when while quering for CUs we find none of them.