Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Feature request: Support "import PropTypes from 'prop-types'" #439

Closed
ekoneko opened this issue Nov 2, 2017 · 3 comments
Closed

Feature request: Support "import PropTypes from 'prop-types'" #439

ekoneko opened this issue Nov 2, 2017 · 3 comments
Labels
enhancement

Comments

@ekoneko
Copy link

ekoneko commented Nov 2, 2017

For example

import PropTypes from 'prop-types';
Component.propTypes = {
  optionalBool: PropTypes.bool
}

We got optionalBool?: any;, not bool.
@ekoneko ekoneko changed the title Support for "import PropTypes from 'prop-types'" Feature request: Support "import PropTypes from 'prop-types'" Nov 3, 2017
@FDiskas
Copy link

FDiskas commented Nov 10, 2017

Yes, that would be nice 📄

@FDiskas FDiskas mentioned this issue Nov 13, 2017
Closed
KnisterPeter added a commit that referenced this issue Nov 22, 2017
@KnisterPeter
feat: support prop-types repository
f5f7337 
Since react move to prop-types it should be supported here as well.

Closes #439
@KnisterPeter KnisterPeter mentioned this issue Nov 22, 2017
Merged
@KnisterPeter
Copy link
Owner

Released in 0.23

@KnisterPeter
Copy link
Owner

Also note that it must be

import  * as PropTypes from 'prop-types';

for typescript

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KnisterPeter @FDiskas @ekoneko