Skip to content

Leaked exception in rx integration #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qwwdfsad opened this issue Oct 15, 2019 · 1 comment
Closed

Leaked exception in rx integration #1614

qwwdfsad opened this issue Oct 15, 2019 · 1 comment
Assignees
@qwwdfsad
Labels
bug flow

Comments

@qwwdfsad
Copy link
Member

Repro:

RxJavaPlugins.setErrorHandler { }
val flow = rxSingle<Unit> { throw IOException("") }.toFlowable().asFlow()
runBlocking {
    repeat(10000) {
        combine(flow, flow) { _, _ -> Unit }
            .catch {}
            .collect { }
    }
}
@qwwdfsad qwwdfsad self-assigned this Oct 15, 2019
@qwwdfsad
Copy link
Member Author

Same root as in #252

qwwdfsad added a commit that referenced this issue Oct 29, 2019
@qwwdfsad
Consistently handle undeliverable exceptions in RxJava and Reactor in…
f6c3446 
…tegrations

Use tryOnError in RxJava to make exception delivery check-and-act race free.
Deliver undeliverable exceptions via RxJavaPlugins instead of handleCoroutineException.
This is a deliberate choice for a multiple reasons:
    * When using Rx (whether with coroutines or not), undeliverable exceptions are inevitable and users should hook into RxJavaPlugins anyway. We don't want to force them using Rx-specific CoroutineExceptionHandler all over the place
    * Undeliverable exceptions provide additional helpful stacktrace and proper way to distinguish them from other unhandled exceptions
    * Be consistent with reactor where we don't have try*, thus cannot provide a completely consistent experience with CEH (at least, without wrapping all the subscribers)

Do the similar in Reactor integration, but without try*, Reactor does not have notion of undeliverable exceoptions and handles them via Operators.* on its own.

Also, get rid of ASCII tables that are not properly render in IDEA

Fixes #252
Fixes #1614
@qwwdfsad qwwdfsad mentioned this issue Oct 29, 2019
Merged
qwwdfsad added a commit that referenced this issue Dec 5, 2019
@qwwdfsad
Consistently handle undeliverable exceptions in RxJava and Reactor in…
8e21810 
…tegrations

Use tryOnError in RxJava to make exception delivery check-and-act race free.
Deliver undeliverable exceptions via RxJavaPlugins instead of handleCoroutineException.
This is a deliberate choice for a multiple reasons:
    * When using Rx (whether with coroutines or not), undeliverable exceptions are inevitable and users should hook into RxJavaPlugins anyway. We don't want to force them using Rx-specific CoroutineExceptionHandler all over the place
    * Undeliverable exceptions provide additional helpful stacktrace and proper way to distinguish them from other unhandled exceptions
    * Be consistent with reactor where we don't have try*, thus cannot provide a completely consistent experience with CEH (at least, without wrapping all the subscribers)

Do the similar in Reactor integration, but without try*, Reactor does not have notion of undeliverable exceoptions and handles them via Operators.* on its own.

Also, get rid of ASCII tables that are not properly render in IDEA

Fixes #252
Fixes #1614
qwwdfsad added a commit that referenced this issue Dec 5, 2019
@qwwdfsad
Consistently handle undeliverable exceptions in RxJava and Reactor in…
556c92f 
…tegrations

Use tryOnError in RxJava to make exception delivery check-and-act race free.
Deliver undeliverable exceptions via RxJavaPlugins instead of handleCoroutineException.
This is a deliberate choice for a multiple reasons:
  * When using Rx (whether with coroutines or not), undeliverable exceptions are inevitable and users should hook into RxJavaPlugins anyway. We don't want to force them using Rx-specific CoroutineExceptionHandler all over the place
  * Undeliverable exceptions provide additional helpful stacktrace and proper way to distinguish them from other unhandled exceptions
  * Be consistent with reactor where we don't have try*, thus cannot provide a completely consistent experience with CEH (at least, without wrapping all the subscribers)\

Do the similar in Reactor integration, but without try*, Reactor does not have notion of undeliverable exceoptions and handles them via Operators.* on its own.

Also, get rid of ASCII tables that are not properly render in IDEA

Fixes #252
Fixes #1614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwwdfsad qwwdfsad

Labels
bug flow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qwwdfsad