-
-
Notifications
You must be signed in to change notification settings - Fork 29
Feature/existing data validation #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I will publish a new version this week. There was a little bug and I add support for partial validation. |
Sorry for taking so long to get back to you. I've been looking a bit deeper into this and I don't feel it's a right fit for this library at this point, but I'll leave it open for now if anyone else should show their support for something like this. For now one could just use the code you created and add an extension method to use it, like this: public static async virtual Task<bool> ValidateExistingDataAsync(this Torrent torrent, string path,
ValidationOptions options = null)
{
var validator = new Validator(torrent, options);
return await validator.ValidateExistingDataAsync(path);
} |
Hi!
May I know why you think it is not a good fit at the moment?
Best regards,
Jonathan
Le 23 janv. 2021 à 11:08, Søren Kruse <[email protected]<mailto:[email protected]>> a écrit :
Sorry for taking so long to get back to you. I've been looking a bit deeper into this and I don't feel it's a right fit for this library at this point, but I'll leave it open for now if anyone else should show their support for something like this.
For now one could just use the code you created and add an extension method to use it, like this:
public static async virtual Task<bool> ValidateExistingDataAsync(this Torrent torrent, string path,
ValidationOptions options = null)
{
var validator = new Validator(torrent, options);
return await validator.ValidateExistingDataAsync(path);
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#51 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEAHCA2T6QFIKDOXNRXA6LDS3LYALANCNFSM4UVQUQTA>.
|
cfe29e1
to
33a31cb
Compare
I'm a bit nitpicky regarding my library and code in general. The focus of this library was always meant to be encoding/decoding bencode. Torrent-handling was added on later as a quick convenience, but never meant to be the main focus. As I said it's still possible to simply use your code as an extension method or similar. Also feel free to fork this repo and use the code directly in your project. |
Add possiblity to validate existing files contained in the torrent file