fix(template): update mypy version of pyproject.toml #11
Conversation
mypy 0.770 is not compatible with python 3.9. The issue was fixed in 0.780 and 0.800 starts to support python 3.9 officially. mypy issue 8614 and 8627 python/mypy#8614 python/mypy#8627
| @@ -114,7 +114,7 @@ coverage = {extras = ["toml"], version = "^5.0.4"} | |||
| # style | |||
| flake8 = "^3.7.9" | |||
| pylint = "^2.4.4" | |||
| mypy = "^0.770" | |||
| mypy = "^0.800" | |||
There was a problem hiding this comment.
I'd suggest using syntax like {% if int({{ cookiecutter.python_version }}) >= 3.7 %} as 3.7 is still officially supported.
There was a problem hiding this comment.
I accidentally found this site quite useful. https://endoflife.date/python
There was a problem hiding this comment.
Good idea. Will update. The link is also interesting!
There was a problem hiding this comment.
Preliminary study shows version comparison with Jinja2 is difficult. I may dive into cookiecutter itself to see if version comparison function is supported. : (
There was a problem hiding this comment.
@tai271828 Is there any update on this one?
There was a problem hiding this comment.
No, QQ. I did not work on this anymore. It's in my wish list of task. Feel free to close the pull request.
There was a problem hiding this comment.
No worries 🙂 Let's make it a draft one so that I know I don't need to review it at this moment.
There was a problem hiding this comment.
Sounds good! Draft is a good idea so we could keep the track.
Yeah I have had dug into this issue and found it is a rabbit hole : (
Lee-W
force-pushed
the
master
branch
2 times, most recently
from
73cb2c2 to
f86de41
Compare
|
I think we've updated mypy version to a higher than this PR proposed. Thus, I'll close this one for now. Please reopen it if you deem otherwise 🙂 |
mypy 0.770 is not compatible with python 3.9. The issue was fixed in
0.780 and 0.800 starts to support python 3.9 officially.
mypy issue 8614 and 8627
python/mypy#8614
python/mypy#8627